feat(providers): add support for GCP KMS #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanda
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
ruanda
force-pushed
the
add-gkms-support
branch
2 times, most recently
from
59e0b28 to
dcd4763
Compare
|
@ruanda please fix lint error. |
|
@ruanda please add some unit tests. |
ruanda
force-pushed
the
add-gkms-support
branch
from
2c27c0d to
38f9a4a
Compare
Signed-off-by: Mateusz Hromada <[email protected]>
Signed-off-by: Mateusz Hromada <[email protected]>
ruanda
force-pushed
the
add-gkms-support
branch
from
38f9a4a to
ed6f58c
Compare
|
@mumoshu Sure, I will work on that |
Signed-off-by: Mateusz Hromada <[email protected]> # Conflicts: # pkg/stringprovider/stringprovider.go # vals.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for GCP KMS. Tested locally.